Skip to content

fix(core): cap session shell output - #45136

Closed
Oxygen56 wants to merge 2 commits into
anomalyco:v2from
Oxygen56:session-shell-cap
Closed

fix(core): cap session shell output#45136
Oxygen56 wants to merge 2 commits into
anomalyco:v2from
Oxygen56:session-shell-cap

Conversation

@Oxygen56

@Oxygen56 Oxygen56 commented Aug 26, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #45099

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Session shell commands use the same 50 KiB preview limit as regular shell output. Large command output remains file-backed for paging, while the model-facing session history receives only the bounded preview.

The conflict resolution keeps the current V2 session refactor and applies the shared limit at the relocated session-shell capture point.

How did you verify your code works?

  • The resolved files match the current V2 implementation except for importing and using the shared output limit at the relocated capture point.
  • The existing large-output regression remains in the merged test source.
  • TypeScript syntax, resolution scope, and diff checks pass.
  • The package test and typecheck require the integrated merge checkout and Bun, so pull-request CI should run them.

Screenshots / recordings

Not applicable.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential duplicate found:

Recommendation: Check if PR #45109 already implements the 50 KiB capping logic or if these PRs address complementary aspects of the same issue (#45099).

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Aug 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • Not all checklist items are checked. Please confirm you have tested locally and have not included unrelated changes.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Aug 31, 2026
@github-actions github-actions Bot closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant